Cb 6263 lefthook #3291
Open
Cb 6263 lefthook #3291
+299
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1
to
+7
| /* | ||
| * CloudBeaver - Cloud Database Manager | ||
| * Copyright (C) 2020-2025 DBeaver Corp and others | ||
| * | ||
| * Licensed under the Apache License, Version 2.0. | ||
| * you may not use this file except in compliance with the License. | ||
| */ |
There was a problem hiding this comment.
lets have license 1 entry point for vscode snippet and license checking via git hooks
There was a problem hiding this comment.
agree, it will be strange to support both of them
| @@ -37,7 +35,7 @@ | |||
| "@types/react-dom": "^19", | |||
| "concurrently": "^9", | |||
| "eslint": "^9.20.1", | |||
| "husky": "^9", | |||
| "lefthook": "^1", | |||
There was a problem hiding this comment.
it didnt workout for me to have githooks after all install scripts. can we do it without need to install lefthook globally?
Wroud
requested changes
Mar 3, 2025
Comment on lines
+1
to
+7
| /* | ||
| * CloudBeaver - Cloud Database Manager | ||
| * Copyright (C) 2020-2025 DBeaver Corp and others | ||
| * | ||
| * Licensed under the Apache License, Version 2.0. | ||
| * you may not use this file except in compliance with the License. | ||
| */ |
There was a problem hiding this comment.
agree, it will be strange to support both of them
| @@ -0,0 +1,57 @@ | |||
| #!/bin/sh | |||
|
|
|||
| if [ "$LEFTHOOK_VERBOSE" = "1" -o "$LEFTHOOK_VERBOSE" = "true" ]; then | |||
There was a problem hiding this comment.
Why do we still have the .husky directory?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.