LobidClient: flexible server URL #223
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clorenz
approved these changes
Feb 13, 2025
morpheus-87
requested changes
Feb 14, 2025
| public class CudamiConfig { | ||
|
|
||
| private Defaults defaults; | ||
| private int offsetForAlternativePaging = 0; | ||
| private String repositoryFolderPath; | ||
| private TypeDeclarations typeDeclarations; | ||
| private UrlAlias urlAlias; | ||
| private String lobidUrl; |
There was a problem hiding this comment.
Sollte das nicht besser vom Typ URI oder URL sein?
|
|
||
| public Locale getLocale() { | ||
| return locale; | ||
| } | ||
| } | ||
|
|
||
| public static class UrlAlias { |
There was a problem hiding this comment.
Braucht es hier auch noch die Getter-Annotation?
|
Der Eintrag im Changelog fehlt auch noch 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.