Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bm webpack5 config fixes #730

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

Bianca-Morris
Copy link
Member

@Bianca-Morris Bianca-Morris commented Jul 18, 2023

Changelog:

  • Remove terser-webpack-plugin dev-dependency, since this is now included in Webpack 5 by default
  • No longer bundle source maps in production builds (just adds to the bundle size and makes site load slower)
    • Note: this may make debugging issues on live environments more difficult, but since less work will be happening on CGAP into the future, shouldn't be as much of an issue as when it was in active development. May not implement this change on SMaHT until that portal is in the same state.
    • Also, no longer using "eval" as devtool (seems we were never supposed to do that -- honestly not sure how this was working before)
  • Re-add build-quick script, since it will now serve a unique purpose, given default builds are running a little long these days
  • Added some comments we can use to easily profile while debugging Webpack
  • Resolve NODE_ENV "Conflicting values for 'process.env.NODE_ENV'" warning

Notes:

  • Need to look into why the builds are taking so much longer than they used to (~3 min or so); more profiling and troubleshooting required
  • Bundle sizes are still larger than we'd like... another thing to look into

Related PRs:

@Bianca-Morris Bianca-Morris requested a review from crfmc July 18, 2023 18:52
@Bianca-Morris Bianca-Morris mentioned this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants