-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap v5, React bootstrap v2, React 18, Redux and Misc. Npm Packages Upgrade #775
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally got around to looking at this. Code looks good aside from one minor detail I mentioned that might be worth backtracking on. I haven't been able to test this locally, however, as my CGAP local env is giving me a bit of trouble at the moment, and I haven't had time to fix it. Could you deploy this to wolf sometime soon and let us know? There are a few final things I want to double check and then this can be merged.
// It appears that Cypress injects a prop into the div on the client side, which doesn't exist on the server side, leading to hydration issues. | ||
// This suppression is temporary and should be removed once the issue is resolved. | ||
// https://github.com/cypress-io/cypress/issues/27204 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like that thread has introduced a new solution to this problem. Might be worth revisiting this and see if this can be removed/replaced with a more permanent solution before merge.
@Bianca-Morris no worries, thanks for the review. It is recently available in cgap-wolf. AFAIK, SPC's release was changed from beta to production. Anyway, we'll redeploy it and keep you posted.
|
@Bianca-Morris FYI, recent version is available in https://cgap-wolf.hms.harvard.edu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a second look and it's looking good. Can you let me know when it is on staging? There is one last thing I'd like to check: the cohort browser. Which isn't available on wolf at the moment.
This pull request primarily addresses the transition from React 17 to React 18, while also including updates for Redux, Auth0, and other third-party integrations heavily used in the portal, ensuring compatibility with React 18.
Ticket: Trello 1 & Trello 2
Related PR: SPC
Updates
Additionally, this pull request implements the migration to Bootstrap v5 and updates to React-Bootstrap v2, ensuring that styles and components are fully compatible with the latest standards.