Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verbose option for logging #9

Merged
merged 6 commits into from
Dec 14, 2023
Merged

Add verbose option for logging #9

merged 6 commits into from
Dec 14, 2023

Conversation

PleaseStopAsking
Copy link

This PR adds a new variable to enable verbose logging on the cron job for easier identification of issues as well as review of any purge/clean-up on snapshots.

Copy link
Owner

@dbrennand dbrennand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PleaseStopAsking

Thank you for your contribution 🙂

Please add yourself to the contributors in the README.

Just one suggestion here, just a cosmetic change really to show the variable is related to cron.

defaults/main.yml Outdated Show resolved Hide resolved
@dbrennand
Copy link
Owner

dbrennand commented Dec 13, 2023

Hi @PleaseStopAsking - Don't worry about the lint errors, I will fix those - hopefully sometime tomorrow 🙂 Since it last ran Ansible-Lint has had loads of updates so new rules are being triggered and causing failures.

@PleaseStopAsking
Copy link
Author

@dbrennand I went ahead and fixed the lint issues reported as they did not require any breaking changes. Feel free to run workflows again time permitting.

@dbrennand dbrennand added the enhancement New feature or request label Dec 14, 2023
@dbrennand dbrennand assigned dbrennand and unassigned dbrennand Dec 14, 2023
@dbrennand
Copy link
Owner

dbrennand commented Dec 14, 2023

LGTM - Thank you @PleaseStopAsking for your contribution to this role 🙂

@dbrennand dbrennand merged commit 7595f3d into dbrennand:main Dec 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants