Limit dbt-tests-adapter build to only produce a wheel
#117
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
…flows to account for building dbt-tests-adapter
mikealfare
changed the title
dbt-tests-adapter build to only produce a wheel
| @@ -59,19 +59,8 @@ jobs: | |||
| uses: ./.github/actions/build-hatch | |||
| with: | |||
| working-dir: "./dbt-tests-adapter/" | |||
|
|
|||
There was a problem hiding this comment.
This whole set of steps were duplicated for some reason.
| uses: ./.github/actions/build-hatch | ||
| with: | ||
| working-dir: "./dbt-tests-adapter/" | ||
| build-command: "hatch build -t wheel" |
There was a problem hiding this comment.
Override the default working directory to cd into the dbt-tests-adapter build directory.
| @@ -73,18 +73,32 @@ defaults: | |||
|
|
|||
| jobs: | |||
| bump-version-generate-changelog: | |||
| name: "Bump package version, Generate changelog" | |||
| name: "Bump package version, Generate changelog - dbt-adapters" | |||
There was a problem hiding this comment.
Duplicate step to provide different configuration for dbt-adapters and dbt-tests-adapter. dbt-tests-adapter has no tests, and hatch needs to be in dbt-tests-adapter to reference the correct pyproject.toml and associated commands.
| archive-name: ${{ inputs.version_number }}-${{ inputs.package }}-${{ inputs.deploy-to }} | ||
| working-dir: "./dbt-tests-adapter/" | ||
| build-command: "hatch build -t wheel" |
There was a problem hiding this comment.
Override the default working directory to cd into the dbt-tests-adapter build directory.
| @@ -53,6 +53,9 @@ on: | |||
| type: string | |||
| required: false | |||
| default: '' | |||
| run-unit-tests: | |||
There was a problem hiding this comment.
Allow for optional unit tests; dbt-tests-adapter has no tests. This should also probably be updated to something like unit-test-command (which could be empty), to follow suit with build-command and check-command.
| @@ -61,6 +64,11 @@ on: | |||
| type: string | |||
| required: false | |||
| default: main | |||
| working-dir: | |||
There was a problem hiding this comment.
Allow for working directory to be passed in so that hatch can reference the correct pyproject.toml.
| @@ -31,14 +31,6 @@ dependencies = [ | |||
| "dbt-adapters", | |||
| "pyyaml", | |||
| ] | |||
|
|
|||
| [project.optional-dependencies] | |||
There was a problem hiding this comment.
This was moved down into the hatch environment dependencies elsewhere. This aligns with that decision.
| @@ -50,6 +42,9 @@ Changelog = "https://github.com/dbt-labs/dbt-adapters/blob/main/CHANGELOG.md" | |||
| requires = ["hatchling"] | |||
| build-backend = "hatchling.build" | |||
|
|
|||
| [tool.hatch.version] | |||
There was a problem hiding this comment.
This got moved from troubleshooting, but it's position now aligns with the root pyproject.toml, so it feels right to keep it here.
| uses: dbt-labs/dbt-adapters/.github/workflows/release_prep_hatch.yml@main | ||
| name: "Bump package version, Generate changelog - dbt-adapters" | ||
| if: ${{ inputs.package == 'dbt-adapters' }} | ||
| uses: dbt-labs/dbt-adapters/.github/workflows/release_prep_hatch.yml@fix-sdist-build |
There was a problem hiding this comment.
Point back to main before merging.
| bump-version-generate-changelog-dbt-tests-adapter: | ||
| name: "Bump package version, Generate changelog - dbt-tests-adapter" | ||
| if: ${{ inputs.package == 'dbt-tests-adapter' }} | ||
| uses: dbt-labs/dbt-adapters/.github/workflows/release_prep_hatch.yml@fix-sdist-build |
There was a problem hiding this comment.
Point back to main before merging.
|
This was resolved by #118 |
Problem
We can't currently build an source distribution for
dbt-tests-adapterbecause of interactions betweenhatch,pyproject.toml, and the fact that this is a monorepo. There are also multiple places in the workflow wheredbt-tests-adapteris not accounted for (e.g. different working directory, lack of hatch commands, etc.).Solution
./dbt-tests-adapterbuildworkflowChecklist