Apply column quoting to unit tests

[dbeatty10]

resolves #205

Note

This is just a prototype of a potential solution, and I probably won't finish it.

Anyone that wants to take it across the finish line in a separate PR and feel free to take any of it that is useful.

Problem

Unit tests do not currently take quoting of column names into account.

Solution

Make sure the locations below are all using quoted column names:

• dbt-adapters/dbt/include/global_project/macros/materializations/tests/helpers.sql

  Line 27 in d831caa

  {% for expected_column_name in expected_column_names %}{{expected_column_name}}{% if not loop.last -%},{% endif %}{%- endfor -%}, {{ dbt.string_literal("actual") }} as {{ adapter.quote("actual_or_expected") }}

• dbt-adapters/dbt/include/global_project/macros/materializations/tests/helpers.sql

  Line 35 in d831caa

  {% for expected_column_name in expected_column_names %}{{expected_column_name}}{% if not loop.last -%}, {% endif %}{%- endfor -%}, {{ dbt.string_literal("expected") }} as {{ adapter.quote("actual_or_expected") }}

• dbt-adapters/dbt/include/global_project/macros/unit_test_sql/get_fixture_sql.sql

  Line 31 in df1b8c3

  {%- for column_name, column_value in default_row_copy.items() %} {{ column_value }} as {{ column_name }}{% if not loop.last -%}, {%- endif %}

• dbt-adapters/dbt/include/global_project/macros/unit_test_sql/get_fixture_sql.sql

  Line 40 in df1b8c3

  {%- for column_name, column_value in default_row.items() %} {{ column_value }} as {{ column_name }}{% if not loop.last -%},{%- endif %}

• dbt-adapters/dbt/include/global_project/macros/unit_test_sql/get_fixture_sql.sql

  Line 56 in df1b8c3

  {%- for column_name, column_value in formatted_row.items() %} {{ column_value }} as {{ column_name }}{% if not loop.last -%}, {%- endif %}

Testing

Here is a potential functional test for this scenario

dbt-tests-adapter/dbt/tests/adapter/unit_testing/test_case_sensitivity.py

import pytest
from dbt.tests.util import run_dbt


my_model_sql = """
select
    1 as {{ adapter.quote("tested_column") }},
    2 as {{ adapter.quote("TESTED_COLUMN") }},
    3 as {{ adapter.quote("TESTed_COLumn") }}
"""

test_my_model_yml = """
unit_tests:
  - name: test_my_model
    model: my_model
    given: []
    expect:
      rows:
          - {tested_column: 1, TESTED_COLUMN: 2, TESTed_COLumn: 3}
"""


class BaseUnitTestCaseSensivity:
    @pytest.fixture(scope="class")
    def models(self):
        return {
            "my_model.sql": my_model_sql,
            "unit_tests.yml": test_my_model_yml,
        }

    def test_case_sensitivity(self, project):
        results = run_dbt(["run"])
        assert len(results) == 1

        results = run_dbt(["test"])


class TestPosgresUnitTestCaseSensitivity(BaseUnitTestCaseSensivity):
    pass

Checklist

• I have read the contributing guide and understand what's expected of me
• I have run this code in development, and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

[github-actions]

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

[github-actions]

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.