[CT-1661] Quotes usernames with special characters #265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #156
Problem
This PR solves the issues where dbt tries to apply grant-related SQL queries against users that have special characters in their names and fails.
Solution
Quotes are added around users that hold special characters. So far, this just includes a few special characters that people have raised issues for across several dbt repos ("." in #156, "-" in #55, and "@" in my case.
Please suggest how this can be tested, I'm not entirely sure about this because the unit-tests seem to pass after I've made this change. Not sure where the tests should be added for this.
Checklist