Skip to content

Commit

Permalink
standardize workflows
Browse files Browse the repository at this point in the history
  • Loading branch information
mikealfare committed Oct 10, 2024
1 parent 961cdaf commit 99305ba
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/merge-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ jobs:
branch: ${{ github.ref }}
strategy:
matrix:
package: ['dbt-athena', 'dbt-athena-community']
package: ["dbt-athena", "dbt-athena-community"]
4 changes: 2 additions & 2 deletions .github/workflows/publish-pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ jobs:
- run: |
hatch build
hatch run build:check-all
working-directory: "./${{ inputs.package }}"
working-directory: ./${{ inputs.package }}
- uses: pypa/gh-action-pypi-publish@release/v1
with:
repository-url: ${{ vars.vars.PYPI_REPOSITORY_URL }}
packages-dir: "${{ inputs.package }}/dist/"
packages-dir: ${{ inputs.package }}/dist/
6 changes: 3 additions & 3 deletions .github/workflows/pull-request-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ concurrency:

jobs:
code-quality:
uses: ./.github/workflows/unit-tests.yml
uses: ./.github/workflows/code-quality.yml
with:
branch: ${{ github.event.pull_request.head.ref }}
repository: ${{ github.event.pull_request.head.repo.full_name }}
Expand All @@ -24,7 +24,7 @@ jobs:
repository: ${{ github.event.pull_request.head.repo.full_name }}
strategy:
matrix:
package: ['dbt-athena', 'dbt-athena-community']
package: ["dbt-athena", "dbt-athena-community"]

integration-tests:
if: contains(github.event.pull_request.labels.*.name, 'ci:integration-tests')
Expand All @@ -35,7 +35,7 @@ jobs:
repository: ${{ github.event.pull_request.head.repo.full_name }}
strategy:
matrix:
package: ['dbt-athena', 'dbt-athena-community']
package: ["dbt-athena", "dbt-athena-community"]

# This job does nothing and is only used for branch protection
pull-request-checks:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ jobs:
unit-tests:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
steps:
Expand All @@ -53,4 +54,4 @@ jobs:
python-version: ${{ matrix.python-version }}
- uses: pypa/hatch@install
- run: hatch run unit-tests
working-directory: "./${{ inputs.package }}"
working-directory: ./${{ inputs.package }}

0 comments on commit 99305ba

Please sign in to comment.