feat: dbt-glue LfTagsConfig compatibility #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kagenihisomi
requested review from
jessedobbelaere,
Jrmyy,
mattiamatrix,
nicor88 and
svdimchenko
as code owners
|
@kagenihisomi please provide a description on what you are "trying" to address, and what lead to your "implementation"! |
|
@kagenihisomi In case you will like to proceed with this PR please fix the CI. |
|
@kagenihisomi could you add the following option for lf-tags config to documentation as well within this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for compatibility with dbt-glue lf_tags_config/tags_table key
https://github.com/aws-samples/dbt-glue/blob/ee2aa88663fd51ffc1ad1a1dbe04321206453386/dbt/adapters/glue/lakeformation.py#L12
In dbt-glue, for table-level LF-tags, "tags_table" key is used. This allows compatibility to use tags_table across both adapters without having to specify different keys