-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #656 #658
base: main
Are you sure you want to change the base?
fix #656 #658
Conversation
WIP, added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good, but I would like to see some functional testing for this issue.
Specifically might be possible to create a batch of data with no records, limiting the result to 0, e.g. select '1' as name limit 0
@antonysouthworth-halter the functional tests are falling, please have a look 🙏🏻 |
…t-athena into fix/656
Description
fixes #656 #519
Models used to test - Optional
Checklist