Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test case when raise ServiceUnavailable in is_retryable #1224

Merged
merged 7 commits into from
Oct 24, 2024

Conversation

jx2lee
Copy link
Contributor

@jx2lee jx2lee commented May 4, 2024

(want to) resolves #682
docs dbt-labs/docs.getdbt.com/#

Problem

some users claims not to retry on BQ 503 errors.

Solution

Add case to the test_is_retryable raises a ServiceUnavailable error.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label May 4, 2024
@jx2lee jx2lee marked this pull request as ready for review May 4, 2024 16:27
@jx2lee jx2lee requested a review from a team as a code owner May 9, 2024 13:55
@mikealfare mikealfare merged commit 79fbd90 into dbt-labs:main Oct 24, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-498] [Bug] BQ does not retry on 503
2 participants