Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry feature to all API calls #1386

Closed
wants to merge 1 commit into from
Closed

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Oct 25, 2024

resolves #682
resolves #1327

Problem

We're not retrying in all scenarios. We need to allow for retries whenever we make a call to BigQuery.

Solution

  • add RefreshError to retry-able errors so that token refreshes don't cause failures due to the IAM service being unavailable
    • this is relevant to errors that mention not being able to reach the IAM service
  • add retry_and_handle to get_bq_table so that we can retry when getting table metadata
    • this is relevant to errors on incremental materializations where dbt needs to get table metadata for the temp table

I still need to review python submissions, which also appear to be generating errors.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Oct 25, 2024
@cla-bot cla-bot bot added the cla:yes label Oct 25, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@mikealfare mikealfare closed this Nov 9, 2024
@mikealfare mikealfare deleted the retry-impersonated-creds branch November 9, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant