Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry factory to consolidate retry strategies across dbt-bigquery #1395

Merged
merged 43 commits into from
Nov 20, 2024
Merged

Add retry factory to consolidate retry strategies across dbt-bigquery #1395

merged 43 commits into from
Nov 20, 2024

Commits on Nov 5, 2024

  1. fix imports

    @mikealfare
    mikealfare committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    2b01804 View commit details
    Browse the repository at this point in the history

  2. create a retry factory and move relevant objects from connections

    @mikealfare
    mikealfare committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    8b45594 View commit details
    Browse the repository at this point in the history

  3. add on_error method for deadline retries

    @mikealfare
    mikealfare committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    391099d View commit details
    Browse the repository at this point in the history

  4. remove dependency on retry_and_handle from cancel_open

    @mikealfare
    mikealfare committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    7872a58 View commit details
    Browse the repository at this point in the history

  5. remove dependencies on retry_and_handle

    @mikealfare
    mikealfare committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    42a8869 View commit details
    Browse the repository at this point in the history

  6. remove timeout methods from connection manager

    @mikealfare
    mikealfare committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    900dcac View commit details
    Browse the repository at this point in the history

  7. add retry to get_bq_table

    @mikealfare
    mikealfare committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    81bfa0c View commit details
    Browse the repository at this point in the history

  8. fix mocks in unit tests

    @mikealfare
    mikealfare committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    3e32872 View commit details
    Browse the repository at this point in the history

  9. rebase on main

    @mikealfare
    mikealfare committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    89e2a50 View commit details
    Browse the repository at this point in the history

  10. reorder this tuple to make the pr review easier to understand

    @mikealfare
    mikealfare committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    3f79642 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. move client factory to credentials module so that on_error can be mov… 

    …ed to the retry factory in the retry module
    @mikealfare
    mikealfare committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    f300080 View commit details
    Browse the repository at this point in the history

  2. move on_error factory to retry module

    @mikealfare
    mikealfare committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    c3065e5 View commit details
    Browse the repository at this point in the history

  3. move client factories from python_submissions module to credentials m… 

    …odule
    @mikealfare
    mikealfare committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ad74114 View commit details
    Browse the repository at this point in the history

  4. create a clients module

    @mikealfare
    mikealfare committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    9029c49 View commit details
    Browse the repository at this point in the history

  5. retry all client factories by default

    @mikealfare
    mikealfare committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    bc0fbea View commit details
    Browse the repository at this point in the history

  6. move polling from manual check in python_submissions module into retr… 

    …y_factory
    @mikealfare
    mikealfare committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    9a9f87e View commit details
    Browse the repository at this point in the history

  7. move load_dataframe logic from adapter to connection manager, use the… 

    … built-in timeout argument instead of a manual polling method
    @mikealfare
    mikealfare committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    136ea77 View commit details
    Browse the repository at this point in the history

  8. move upload_file logic from adapter to connection manager, use the bu… 

    …ilt-in timeout argument instead of a manual polling method, remove the manual polling method
    @mikealfare
    mikealfare committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    90d5308 View commit details
    Browse the repository at this point in the history

  9. move the retry to polling for done instead of create

    @mikealfare
    mikealfare committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    9211e1c View commit details
    Browse the repository at this point in the history

  10. fix broken import in tests from code migration

    @mikealfare
    mikealfare committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    e90c24d View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. align new retries with original methods, simplify retry factory

    @mikealfare
    mikealfare committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a2db35b View commit details
    Browse the repository at this point in the history

  2. fix seed load result

    @mikealfare
    mikealfare committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    b8408c2 View commit details
    Browse the repository at this point in the history

  3. create a method for the dataproc endpoint

    @mikealfare
    mikealfare committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    5b896ee View commit details
    Browse the repository at this point in the history

  4. add some readability updates

    @mikealfare
    mikealfare committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    43c10f1 View commit details
    Browse the repository at this point in the history

  5. add some readability updates

    @mikealfare
    mikealfare committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    4256682 View commit details
    Browse the repository at this point in the history

  6. add some readability updates, simplify submit methods

    @mikealfare
    mikealfare committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    5644509 View commit details
    Browse the repository at this point in the history

  7. make imports explicit, remove unused constant

    @mikealfare
    mikealfare committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    df2971b View commit details
    Browse the repository at this point in the history

  8. changelog

    @mikealfare
    mikealfare committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    0beaac6 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. add community member who contributed a solution and research to the c… 

    …hangelog
    @mikealfare
    mikealfare committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    6e2f4b4 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Merge branch 'main' into add-retry-factory

    @mikealfare
    mikealfare authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    b560554 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Merge branch 'main' into add-retry-factory

    @colin-rogers-dbt
    colin-rogers-dbt authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    6354483 View commit details
    Browse the repository at this point in the history

  2. update names in clients.py to follow the naming convention

    @mikealfare
    mikealfare committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f72da43 View commit details
    Browse the repository at this point in the history

  3. update names in connections.py to follow the naming convention

    @mikealfare
    mikealfare committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    9fb25bc View commit details
    Browse the repository at this point in the history

  4. update names in credentials.py to follow the naming convention

    @mikealfare
    mikealfare committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e99d857 View commit details
    Browse the repository at this point in the history

  5. update names in python_submissions.py to follow the naming convention

    @mikealfare
    mikealfare committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f8ad953 View commit details
    Browse the repository at this point in the history

  6. update names in retry.py to follow the naming convention

    @mikealfare
    mikealfare committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    5f3a456 View commit details
    Browse the repository at this point in the history

  7. run linter and update unit test mocks

    @mikealfare
    mikealfare committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7c4388f View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. update types on retry factory

    @mikealfare
    mikealfare committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    5928098 View commit details
    Browse the repository at this point in the history

  2. update inputs on retry factory

    @mikealfare
    mikealfare committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    02385bb View commit details
    Browse the repository at this point in the history

  3. update predicate class name

    @mikealfare
    mikealfare committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    51cc87f View commit details
    Browse the repository at this point in the history

  4. add retry strategy back to copy table

    @mikealfare
    mikealfare committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    eaab976 View commit details
    Browse the repository at this point in the history

  5. linting and fix unit test for new argument

    @mikealfare
    mikealfare committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    a81289f View commit details
    Browse the repository at this point in the history

  6. fix whitespace

    @mikealfare
    mikealfare committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    76d6979 View commit details
    Browse the repository at this point in the history