Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove walrus operator to make 1.5 py37 compatible #868

Closed
wants to merge 2 commits into from

Conversation

mikealfare
Copy link
Contributor

Problem

We backported a change to v1.5 that used the walrus operator, which was introduces in py38. While our goal is to drop support for py37 going forward, this is a small change that would keep v1.5 py37 compatible for a bit longer.

Solution

Replace the walrus operator with an equivalent two lines.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Aug 8, 2023
@mikealfare mikealfare requested a review from a team as a code owner August 8, 2023 15:32
@cla-bot cla-bot bot added the cla:yes label Aug 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@mikealfare mikealfare marked this pull request as draft August 9, 2023 00:21
@mikealfare
Copy link
Contributor Author

I converted this to a draft since we might choose to remove testing for py37 as an alternative.

@mikealfare
Copy link
Contributor Author

We are instead choosing to remove py37 testing. This is not needed.

@mikealfare mikealfare closed this Aug 10, 2023
@mikealfare mikealfare deleted the bug/1.5.latest/walrus-operator branch August 16, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants