Fix quoted identifiers in the generate_base_model
macro for BigQuery
#199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #205
resolves #193
Problem
There's some code that adds quoted identifiers for bigquery in a hard-coded fashion. It doesn't handle when a column name in BigQuery needs to be quoted such as a reserved keyword or a column that starts with a number.
Solution
Use
adapter.quote
to create a case-sensitive quoted identifier for column names since it is designed precisely for this type of use-case.🎩
From CI for BigQuery:
Checklist