Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try removing Redshift-specific logic for toggling case-sensitive identifiers #208

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

dbeatty10
Copy link
Contributor

resolves #206

Problem

We have hard-coded logic just for Redshift that toggles a setting to enable case-sensitive identifiers. This makes the code harder to read and maintain.

Solution

  1. Ensure that the Redshift cluster for running CI tests has enable_case_sensitive_identifier set to true (rather than the default of false).
  2. Remove the prior logic that toggled this setting on an as-needed basis.

Checklist

@dbeatty10 dbeatty10 marked this pull request as ready for review November 21, 2024 14:36
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 21, 2024
@dbeatty10 dbeatty10 merged commit 696c9f0 into main Nov 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the Redshift-specific logic for enable_case_sensitive_identifier
1 participant