-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microbatch: event_time ref + source filtering #10594
Merged
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
c4930e9
initial rough-in with CLI flags
MichelleArk 4c8528b
dbt-adapters testing against event-time-ref-filtering
MichelleArk 3bb6807
Merge branch 'main' into event-time-ref-filtering
MichelleArk f5d5bb6
fix TestList
MichelleArk 19ad7c6
Checkpoint
QMalcolm a57481f
fix tests
MichelleArk 25c10f7
add event_time_start params to build
MichelleArk 699179f
rename configs
MichelleArk 2d19d1c
Gate resolve_event_time_filter via micro batch strategy and fix strpt…
QMalcolm 57b1353
Add unit test for resolve_event_time_filter
QMalcolm e0bae27
Additional unit tests for `resolve_event_time_filter` to ensure lookb…
QMalcolm 1313aff
Remove extraneous comments and print statements from resolve_event_ti…
QMalcolm 7307c02
Fixup microbatch functional tests to use microbatch strategy
QMalcolm 838a0aa
Gate microbatch functionality behind env_var while in beta
QMalcolm 43715de
Add comment about how _is_incremental should be removed
QMalcolm e38ff47
Improve `event_time_start/end` cli parameters to auto convert to date…
QMalcolm 457698c
for testing: dbt-postgres 'microbatch' strategy
MichelleArk 3a4fa7f
Make event_time model configs `Any` so as to not break people already…
QMalcolm 8cc1c7d
Rename `PartitionGrain` to `BatchSize`
QMalcolm 1b0a904
fix error message about batch size
QMalcolm 7522b9b
Create unit test to check values which gate off event_time usage
QMalcolm 5f72534
Add unit test case in regard to event_tiem filtering when `is_increme…
QMalcolm a8b9d64
Cleanup unit test for test_resolve_event_time_filter_batch_calculation
QMalcolm 174db0a
Merge branch 'main' into event-time-ref-filtering
QMalcolm b85d50e
Update lower bound of dbt-adapters req to 1.5.0
QMalcolm ec01129
Update dev-reqs now that the changes we need have been merged to main…
QMalcolm 8f8e7e3
Remove `is_incremental` check from `_build_end_time`
QMalcolm 2b80f75
Improve help messages for `event_time_start/end` CLI flags
QMalcolm 0eb8e2f
Improve error handling messages for event time filtering generation
QMalcolm 3a6c739
Merge branch 'main' into event-time-ref-filtering
QMalcolm 1690d81
Delete pairing.md file
QMalcolm de87286
Add changie doc for initial microbatch implementation
QMalcolm 12bfec9
Update v12.json manifest schema for NodeConfig changes
QMalcolm 9b47966
Add `event_time` to `SourceConfig` and allow event time filtering for…
QMalcolm 6767948
Add test that asserts direct upstrean inputs without event_time aren'…
QMalcolm 61123cb
Add test asserting that calling `.render()` on a ref skips event time…
QMalcolm 43866db
Update v12 manifest schema with new SourceConfig key for event_time
QMalcolm 5426e66
fix test_list for source config event_time
MichelleArk ee29fed
restore dbt-postgres dev requirement
MichelleArk 3020aa4
Update dbt-adapters minimum version to 1.6.0
QMalcolm f53204f
fix test_artifacts; add event_time to expected_manifest
MichelleArk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Features | ||
body: Add basic functionality for creating microbatch incremental models | ||
time: 2024-09-11T12:10:29.822189-05:00 | ||
custom: | ||
Author: MichelleArk QMalcolm | ||
Issue: 9490 10635 10637 10638 10636 10662 10639 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,7 @@ | |
@dataclass | ||
class SourceConfig(BaseConfig): | ||
enabled: bool = True | ||
event_time: Any = None | ||
|
||
|
||
@dataclass | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the event_time, batch_size, and lookback fields as
Any
to avoid any regressions (e.g. parsing failures for projects that make use of these configs).We will be adding parse-time validation for microbatch models in a downstream PR.