Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flags to json schema #146

Merged
merged 6 commits into from
Jul 11, 2024
Merged

Conversation

pquadri
Copy link
Contributor

@pquadri pquadri commented Jun 18, 2024

closes #141

small note: i did not sort the keys with the extension as a good chunk of the file isn't and i didn't want to produce a huge diff

@aleix-cd
Copy link

Out of curiosity: shouldn't the flags object also accept all the global config flags specified here (where Supported in project? = ✅ )?

@pquadri
Copy link
Contributor Author

pquadri commented Jun 20, 2024

Out of curiosity: shouldn't the flags object also accept all the global config flags specified here (where Supported in project? = ✅ )?

guess so, i ignored the first part of https://github.com/dbt-labs/dbt-core/blob/d389ff1450e72c51eee443facf779736677768bb/core/dbt/contracts/project.py#L322 😅 , updating

@joellabes
Copy link
Collaborator

@pquadri thank you for opening this! (And sorry for the delay getting back to you).

Looks great - just waiting for the checks to pass and I'll get this merged! There's some custom sort logic in .vscode/settings.json which if your sorter doesn't align with would lead to weird diffs. I ran it locally for you.

I've also removed the flags from dbt_project.json which is legacy from <1.4 and only exists for backwards compatibility reasons.

@joellabes joellabes merged commit 3060aa0 into dbt-labs:main Jul 11, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User config should be defined in flags in dbt_project.yml now, not profiles.yml
3 participants