[Regression] Fix psycopg2 version install #113
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-postgres contributing guide. |
…it is not implemented
|
Just a naive question -- does doing this lose us anything? I assume no but worth asking as we're moving to the binary. |
The only thing this really impacts is if you're looking for better performance out of |
|
|
||
| PSYCOPG2_NAME=$((pip show psycopg2 || pip show psycopg2-binary) | grep Name | cut -d " " -f 2) | ||
| if [[ "$PSYCOPG2_NAME" != "$PSYCOPG2_EXPECTED_NAME" ]]; then | ||
| echo -e 'Expected: "$PSYCOPG2_EXPECTED_NAME" but found: "$PSYCOPG2_NAME"' |
There was a problem hiding this comment.
nit: can we pipe this to stderr >&2
resolves #96
Problem
We broke folks who were installing
dbt-postgreson Linux and expectingpsycopg2-binaryinstead ofpsycopg2. This is an issue becausepsycopg2expects some OS level dependencies whereaspsycopg2-binarydoes not. In particular, this broke a lot of CI workflows which traditionally run on some flavor of Linux.Solution
psycopg2-binaryeverywherehatchpost-build hook that looks for the environment variableDBT_PSYCOPG2_NAMEand swaps outpsycopg2-binaryforpsycopg2and hard pins to the same versionChecklist