Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation warning when filter is applied to conversion input measure #350

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

WilliamDee
Copy link
Contributor

@WilliamDee WilliamDee commented Sep 27, 2024

Resolves SL-2862

Description

Since filtering on a conversion input measure is not fully supported, we will add a warning when this is added to let the user know.

Checklist

Copy link

linear bot commented Sep 27, 2024

Copy link
Contributor

@courtneyholcomb courtneyholcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was so fast 😂
Thank you also for the cleanup!!
Note that this will need a version bump (prod version) so we can release it and get it into core. And then a core PR that bumps to that version.

dbt_semantic_interfaces/validations/metrics.py Outdated Show resolved Hide resolved
dbt_semantic_interfaces/validations/metrics.py Outdated Show resolved Hide resolved
@WilliamDee WilliamDee force-pushed the will/add-conversion-filter-validations branch from a27a6a5 to 2968a8b Compare September 27, 2024 19:57
@WilliamDee
Copy link
Contributor Author

Note that this will need a version bump (prod version) so we can release it and get it into core. And then a core PR that bumps to that version.

@courtneyholcomb Are there any other validation tasks? Would it make sense to wait for some of those to be done then we can batch all those up and release it once?

@courtneyholcomb
Copy link
Contributor

Note that this will need a version bump (prod version) so we can release it and get it into core. And then a core PR that bumps to that version.

@courtneyholcomb Are there any other validation tasks? Would it make sense to wait for some of those to be done then we can batch all those up and release it once?

@WilliamDee
Good call, yeah I think there are! Can you put up a task to make sure we don't forget?

@WilliamDee WilliamDee merged commit a462190 into main Sep 30, 2024
22 checks passed
@WilliamDee WilliamDee deleted the will/add-conversion-filter-validations branch September 30, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants