Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create fabricspark-setup.md #5038

Draft
wants to merge 9 commits into
base: current
Choose a base branch
from
Draft

Create fabricspark-setup.md #5038

wants to merge 9 commits into from

Conversation

prdpsvs
Copy link
Contributor

@prdpsvs prdpsvs commented Mar 5, 2024 •
edited
Loading

Setting up documentation for new adapter Fabric Spark?

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@prdpsvs prdpsvs requested a review from a team as a code owner March 5, 2024 03:19
@vercel Vercel
Copy link

vercel bot commented Mar 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ❌ Failed (Inspect) Mar 22, 2024 10:50am

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address labels Mar 5, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 5, 2024

@prdpsvs is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@prdpsvs prdpsvs requested a review from dataders as a code owner March 5, 2024 04:41
@github-actions github-actions bot added size: large This change will more than a week to address and might require more than one person and removed size: medium This change will take up to a week to address labels Mar 5, 2024
@mirnawong1
Copy link
Contributor

hey @dataders , will review this pr and let me know if there are any questions!

mirnawong1
mirnawong1 reviewed Mar 22, 2024
View reviewed changes
website/sidebars.js Outdated Show resolved Hide resolved
@mirnawong1
Copy link
Contributor

mirnawong1 commented Mar 22, 2024 •
edited
Loading

hey @prdpsvs , thanks for opening this pr. just double checking - the repo microsoft/dbt-fabricspark doesn't seem to exist? cc @dataders

mirnawong1
mirnawong1 reviewed Mar 22, 2024
View reviewed changes
website/docs/docs/core/connect-data-platform/fabricspark-setup.md


<Snippet path="warehouse-setups-cloud-callout" />
<Snippet path="dbt-fabricspark-for-fabricspark" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @prdpsvs - it doesn't look like there's a file for this snippet. is this something you're planning on adding? the deploy is failing bc it can't find fabricspark-for-fabricspark.md.

@matthewshaver
Copy link
Contributor

Hi @prdpsvs & @amychen1776 - It looks like there are some outstanding questions in this PR. Is this still something we want to move forward with at this time, move to draft, or close out?

@amychen1776
Copy link
Collaborator

@matthewshaver can you move it to draft? @prdpsvs is currently out on pat leave

@matthewshaver matthewshaver marked this pull request as draft August 6, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 left review comments

@dataders dataders Awaiting requested review from dataders dataders is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
content Improvements or additions to content size: large This change will more than a week to address and might require more than one person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prdpsvs @mirnawong1 @matthewshaver @amychen1776