-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add vale linting to docs as ci check #5623
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm! This looks like a really great tool. I like that it's scoped only to markdown files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is amazing work, @mirnawong1 ! left last comment here https://github.com/dbt-labs/docs.getdbt.com/pull/5934/files#r1784766100
approving!
as part of the 2024 epd mentorship, adding vale linting as ci check for our internal and external contributors. this pr also add the vale configuration based on our style guide.
this is a basic configuration that checks for things like: