Vale: test with one file #5933
Open
Vale: test with one file #5933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
nghi-ly
commented
Aug 15, 2024
There was a problem hiding this comment.
this is amazing, @mirnawong1 !
a couple of questions:
-
since this is just a warning not an error, should the CI check still show up as failed/red? for only warnings, i expected pass/green.
-
i took a look at the Vale details log. i see that "reviewdog" errored out (screenshot below), which was unexpected to me. is this normal/expected behavior?
| @@ -9,7 +9,7 @@ Trusted adapters take part in the Trusted Adapter Program, including a commitmen | |||
|
|
|||
| Free and open-source tools for the data professional are increasingly abundant. This is by-and-large a *good thing*, however it requires due diligence that wasn't required in a paid-license, closed-source software world. As a user, there are questions to answer important before taking a dependency on an open-source project. The trusted adapter designation is meant to streamline this process for end users. | |||
|
|
|||
| ### Trusted adapter specifications | |||
| ### Trusted Adapter Specifications | |||
|
|
|||
There was a problem hiding this comment.
love the Vale warning for line 12!
github-actions
bot
removed
the
size: x-small
github-actions
bot
added
the
size: small
github-actions
bot
added
size: x-small
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
Test linter with just one file and one line edit