Vale: test with several files #5934
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
There was a problem hiding this comment.
this test with many edited files is a bit interesting, @mirnawong1 .
- Vale didn't flag anything on 2 (out of 3) files. i expected for some lines to be flagged. i wonder if this has something to do with "reviewdog" erroring out.
- Vale flagged several lines in the 3rd file but there were some false positives.
|
|
||
| ## System of a noun: deciding what happens where | ||
| ## Fabric Best Practices |
There was a problem hiding this comment.
hmm, i expected Vale to flag this line but it didn't
| models will still query from the same raw data source in Snowflake. By using `source`, you can | ||
| test and document your raw data and also understand the lineage of your sources. | ||
|
|
||
| </div> |
There was a problem hiding this comment.
End of file. Vale didn't flag anything for this file, which seems unusual. i expected at least a "typo" warning.
| the `range` dict to generate the partitioning clause for the table. | ||
|
|
||
| <Tabs | ||
| defaultValue="source" |
There was a problem hiding this comment.
our custom components shouldn't get flagged as typos. is it possible to ignore these or maybe add these to our custom dictionary?
| BigQuery supports an [older mechanism of partitioning](https://cloud.google.com/bigquery/docs/partitioned-tables#ingestion_time) based on the time when each row was ingested. While we recommend using the newer and more ergonomic approach to partitioning whenever possible, for very large datasets, there can be some performance improvements to using this older, more mechanistic approach. [Read more about the `insert_overwrite` incremental strategy below](#copying-ingestion-time-partitions). | ||
|
|
||
| dbt will always instruct BigQuery to partition your table by the values of the column specified in `partition_by.field`. By configuring your model with `partition_by.time_ingestion_partitioning` set to `True`, dbt will use that column as the input to a `_PARTITIONTIME` pseudocolumn. Unlike with newer column-based partitioning, you must ensure that the values of your partitioning column match exactly the time-based granularity of your partitions. | ||
|
|
There was a problem hiding this comment.
"time-based" shouldn't be flagged as a typo
i see another instances of this on this file
|
Vale linting found issues. Please check the 'Files change' tab for detailed results. Link to detailed report: Files changed |
|
Vale linting found issues. Please check the 'Files change' tab for detailed results. Link to detailed report: Files changed |
|
Vale linting found issues. Please check the 'Files change' tab for detailed results. Link to detailed report: Files changed |
|
❗️Oh no, some Vale linting found issues! Please check the 'Files change' tab for detailed results and make the necessary updates ✨. ➡️ Link to detailed report: Files changed |
|
❗️Oh no, some Vale linting found issues! Please check the Files change tab for detailed results and make the necessary updates. ➡️ Link to detailed report: Files changed |
What are you changing in this pull request and why?
Testing linter with several files