Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting option for CI jobs #6076

Merged
merged 14 commits into from
Sep 25, 2024
Merged

Linting option for CI jobs #6076

merged 14 commits into from
Sep 25, 2024

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Sep 17, 2024 •
edited
Loading

What are you changing in this pull request and why?

Beta docs for the new Linting option for CI jobs

  • Update CI jobs page with new option and new prereq
  • Update Continuous integration page with new "SQL Linting" section
  • Add "beta" pills appropriately

Checklist

@nghi-ly nghi-ly requested a review from a team as a code owner September 17, 2024 18:12
@vercel Vercel
Copy link

vercel bot commented Sep 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com 🛑 Canceled (Inspect) Sep 25, 2024 3:50pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. Docs team Authored by the Docs team @dbt Labs labels Sep 17, 2024
@nghi-ly nghi-ly requested review from reubenmc and a team and removed request for a team September 17, 2024 18:16
reubenmc
reubenmc reviewed Sep 20, 2024
View reviewed changes
website/docs/docs/deploy/continuous-integration.md Outdated Show resolved Hide resolved
website/docs/docs/deploy/continuous-integration.md Outdated Show resolved Hide resolved
website/docs/docs/deploy/ci-jobs.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Sep 24, 2024
reubenmc
reubenmc approved these changes Sep 24, 2024
View reviewed changes
Copy link

@reubenmc reubenmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mirnawong1
mirnawong1 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small suggs for shortening sentences but other than that, looks great to me!

@nghi-ly
Copy link
Contributor Author

nghi-ly commented Sep 25, 2024

great sugg, mirna! folded them in with minor adjustments. thank you!

@nghi-ly nghi-ly enabled auto-merge (squash) September 25, 2024 15:46
@nghi-ly nghi-ly merged commit 49ba8f3 into current Sep 25, 2024
10 checks passed
@nghi-ly nghi-ly deleted the ly-docs-ci-linting branch September 25, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

@reubenmc reubenmc reubenmc approved these changes

Assignees
No one assigned
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nghi-ly @reubenmc @mirnawong1