-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guides V2 #6855
Merged
Merged
Guides V2 #6855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
john-rock
commented
Jan 30, 2025
JKarlavige
requested changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JKarlavige
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Awesome work with this 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
content
Improvements or additions to content
guides
Knowledge best suited for Guides
size: large
This change will more than a week to address and might require more than one person
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
Documentation will be updated with the following as well before the PR is merged.
This PR introduces several updates to the Guides collection.
Guide index page has been refactor to pull the initial content from a _config markdown file - This will allow the team to set which guides initially appear on the page as well as the categories they appear under.
Sidebar and filter refactor - In addition to a new sidebar, the filters within the sidebar have also been refactored in an effort to make it easier to add filters in the future. The FILTER_CONFIG object within the guide index.js file allows new filters to be added simply by creating a new object within the config and setting the correct values. The filter sidebar will automatically be populated from
FILTER_CONFIG
.Favorites
category. Because of the limitations on the platform, the saved favorite values will be written to local storage meaning that favorites will only appear on the browser they were favorited on, the same way the progress is saved on the guides.last_updated
value on the guide markdown file. The user writing the guide can manually add the date that the guide was updated, we then take that date and pass it into a function which calculates if the guide was updated within the last 10 days. If the guide was updated in the last 10 days an Updated tag will automatically show. If the guide has been updated more than 10 days ago then theUpdated
tag will automatically be removed.Testing steps
_config.md
.select all
,clear all
, andview all
buttons work in the sidebar.Favorite
category.Updated
tag visible.Updated
tag visible. (A past last_updated value has been set on this guide to demonstrate the automatically updating tag which will be removed before merging.)_config.md
is not visible anywhere in the docs content.Before merge
athena-qs
azure-synapse-analytics
🚀 Deployment available! Here are the direct links to the updated files: