-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add execute_timeout to GQL Client in Python SDK #6919
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -18,6 +18,7 @@ Release notes are grouped by month for both multi-tenant and virtual private clo | |||
|
|||
## February 2025 | |||
|
|||
- **Enhancement**: The [Python SDK](/docs/dbt-cloud-apis/sl-python) has improved stability by increasing the default `execute_timeout` in GraphQL from 10s to 30s to reduce test flakiness (inconsistent results). This is particularly useful for the "execute query sync" endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@serramatutu is the timeout configurable or is it set to 30 secs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hiya @mirnawong1
Thanks for creating this. No suggestions from me. I've approved this for you.
Kind Regards
Natalie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! So the test flakiness was happening internally and it didn't actually affect customers. What we changed in the SDK that does affect customers is we added a new "timeout" parameter which can be used to specify timeouts if customers want it.
They can either pass in a number or a "TimeoutOptions" in this parameter to control connect, execute and close timeouts granularly.
oh ok thanks @serramatutu ! so based on this, do we want to say:
|
yes! |
update rn
great stuff, thanks so much! merging @serramatutu ! |
this pr adds a SL rn entry documenting a public change to the python sdk. added execute_timeout to GQL client in python sdk.
linear
🚀 Deployment available! Here are the direct links to the updated files: