Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execute_timeout to GQL Client in Python SDK #6919

Merged
merged 9 commits into from
Feb 18, 2025
Merged

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Feb 17, 2025

this pr adds a SL rn entry documenting a public change to the python sdk. added execute_timeout to GQL client in python sdk.

linear


🚀 Deployment available! Here are the direct links to the updated files:

@mirnawong1 mirnawong1 requested a review from a team as a code owner February 17, 2025 10:12
Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Feb 18, 2025 10:18am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. Docs team Authored by the Docs team @dbt Labs labels Feb 17, 2025
@@ -18,6 +18,7 @@ Release notes are grouped by month for both multi-tenant and virtual private clo

## February 2025

- **Enhancement**: The [Python SDK](/docs/dbt-cloud-apis/sl-python) has improved stability by increasing the default `execute_timeout` in GraphQL from 10s to 30s to reduce test flakiness (inconsistent results). This is particularly useful for the "execute query sync" endpoint.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serramatutu is the timeout configurable or is it set to 30 secs?

Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

Thanks for creating this. No suggestions from me. I've approved this for you.

Kind Regards
Natalie

Copy link

@serramatutu serramatutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! So the test flakiness was happening internally and it didn't actually affect customers. What we changed in the SDK that does affect customers is we added a new "timeout" parameter which can be used to specify timeouts if customers want it.

They can either pass in a number or a "TimeoutOptions" in this parameter to control connect, execute and close timeouts granularly.

@mirnawong1
Copy link
Contributor Author

Hey! So the test flakiness was happening internally and it didn't actually affect customers. What we changed in the SDK that does affect customers is we added a new "timeout" parameter which can be used to specify timeouts if customers want it.

They can either pass in a number or a "TimeoutOptions" in this parameter to control connect, execute and close timeouts granularly.

oh ok thanks @serramatutu ! so based on this, do we want to say:

Added a new timeout parameter to Semantic Layer client and to the underlying GraphQL clients to specify timeouts. Set timeout number or total_timeout in the global TimeoutOptions to control connect, execute and close timeouts granularly. ExponentialBackoff.timeout_ms` is now deprecated.

@serramatutu
Copy link

yes!

@mirnawong1
Copy link
Contributor Author

great stuff, thanks so much! merging @serramatutu !

@mirnawong1 mirnawong1 enabled auto-merge February 18, 2025 10:15
@mirnawong1 mirnawong1 merged commit 59078a8 into current Feb 18, 2025
8 checks passed
@mirnawong1 mirnawong1 deleted the python-timeout branch February 18, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants