Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add bfdcampos/source_db #289

Merged
merged 2 commits into from
Oct 2, 2023
Merged

re-add bfdcampos/source_db #289

merged 2 commits into from
Oct 2, 2023

Conversation

joellabes
Copy link
Contributor

@joellabes joellabes commented Oct 2, 2023

Description

Tell us about your new package!

Link to your package's repository: https://github.com/bfdcampos/source_db

Second attempt at adding package after needing to revert #280 because it seemed to crash hubcap for some reason

@joellabes joellabes requested a review from dbeatty10 as a code owner October 2, 2023 23:15
@joellabes joellabes merged commit 7bfbf1e into main Oct 2, 2023
5 checks passed
joellabes added a commit that referenced this pull request Oct 3, 2023
@joellabes
Copy link
Contributor Author

@dbeatty10 Every time I merge this, Hubcap stops running and detecting other package updates, so I have reverted the PR. Any ideas why this might be? It seems to have the expected components in dbt_project.yml etc.

cc @BfdCampos (sorry!)

@BfdCampos
Copy link
Contributor

No worries @joellabes! Having a look as well in case there was something I did wrong but really I can't seem to find anything that's sticking out.

I did find an example package that was added a few months ago that only described the macro-paths. Whereas mine described all the rest test-path, log-path, etc.

That's the only major thing I can think of but please do let me know if there's anything I can do from my side to help 😊

@BfdCampos
Copy link
Contributor

Hi @joellabes @dbeatty10

Been a while but just wanted to check if we have capacity to see if we can merge this package? We're currently building multiple dbt projects for our teams and would be keen to import this as a package rather than a custom individual macro for each project.

Thanks.

@dbeatty10
Copy link
Contributor

@joellabes I don't know why it is crashing hubcap 😨

I'd suggest running hubcap in a test mode as described here and see if it crashes or not.

@joellabes
Copy link
Contributor Author

@BfdCampos I worked it out! The 0.1.0 release of the package is incorrectly structured, and hubcap can't find a dbt_project.yml file. I think if you delete that release + tag from GitHub then it should be OK

@BfdCampos
Copy link
Contributor

BfdCampos commented Apr 17, 2024

That's awesome news! I have deleted the 0.1.0 release and tag, the latest release is at 0.1.5. Hubcap should get the latest release right? Or is there anything else I need to do from my side? Would we be able to use the original PR adding source_db to hubcap?

@joellabes
Copy link
Contributor Author

Hoping that this will work now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants