Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding gmdata-co to hub.json #298

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

jeff-skoldberg-gmds
Copy link
Contributor

@jeff-skoldberg-gmds jeff-skoldberg-gmds commented Jan 14, 2024

Description

Tell us about your new package!

This package is the first in a series of packages to come that aim at making connectors from Portable.io easier to use.
This packages contains a single macro that will unnest the json payload from Portable's Google Sheets connector.
It transforms the single variant column called "ROWDATA" back to the original columns as they existed in the Google Sheet.

Since this is my first time doing this, I'm not 100% clear on how this all works. I guessed the naming convention in hub.json is:
org-name: [repo-name]... but that was not clear to me from the docs. I guess somehow it automatically will link to my repo based on that?

I have questions about versioning. Can you hit me up on Slack so I can ask? I'm Jeff Skoldberg on dbt Slack.
Can I update the readme without updating the version? Example, I will need to update the install instructions in the readme if this is going live.

Link to your package's repository:
https://github.com/gmdata-co/dbt-portable-google-sheets

Checklist

This checklist is a cut down version of the best practices that we have identified as the package hub has grown. Although meeting these checklist items is not a prerequisite to being added to the Hub, we have found that packages which don't conform provide a worse user experience.

First run experience

  • The package includes a README which explains how to get started with the package and customise its behaviour
  • The README indicates which data warehouses/platforms are expected to work with this package

Customisability

  • The package uses ref or source, instead of hard-coding table references.

Packages for data transformation (delete if not relevant):

  • provide a mechanism (such as variables) to customise the location of source tables.
  • do not assume database/schema names in sources.

Dependencies

Dependencies on dbt Core

  • The package has set a supported require-dbt-version range in dbt_project.yml. Example: A package which depends on functionality added in dbt Core 1.2 should set its require-dbt-version property to [">=1.2.0", "<2.0.0"].

Dependencies on other packages defined in packages.yml:

  • Dependencies are imported from the dbt Package Hub when available, as opposed to a git installation.
  • Dependencies contain the widest possible range of supported versions, to minimise issues in dependency resolution.
  • In particular, dependencies are not pinned to a patch version unless there is a known incompatibility.

Interoperability

  • The package does not override dbt Core behaviour in such a way as to impact other dbt resources (models, tests, etc) not provided by the package.
  • The package uses the cross-database macros built into dbt Core where available, such as {{ dbt.except() }} and {{ dbt.type_string() }}.
  • The package disambiguates its resource names to avoid clashes with nodes that are likely to already exist in a project. For example, packages should not provide a model simply called users.

Versioning

  • (Required): The package's git tags validates against the regex defined in version.py
  • The package's version follows the guidance of Semantic Versioning 2.0.0. (Note in particular the recommendation for production-ready packages to be version 1.0.0 or above)

@joellabes
Copy link
Contributor

lgtm! I've sent you a slack message re your versioning questions

@joellabes joellabes merged commit 3d24c4b into dbt-labs:main Jan 16, 2024
3 checks passed
@jeff-skoldberg-gmds jeff-skoldberg-gmds deleted the add-gmdata branch January 16, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants