Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tell us about your new package!
This package is the first in a series of packages to come that aim at making connectors from Portable.io easier to use.
This packages contains a single macro that will unnest the json payload from Portable's Google Sheets connector.
It transforms the single variant column called "ROWDATA" back to the original columns as they existed in the Google Sheet.
Since this is my first time doing this, I'm not 100% clear on how this all works. I guessed the naming convention in hub.json is:
org-name: [repo-name]... but that was not clear to me from the docs. I guess somehow it automatically will link to my repo based on that?
I have questions about versioning. Can you hit me up on Slack so I can ask? I'm Jeff Skoldberg on dbt Slack.
Can I update the readme without updating the version? Example, I will need to update the install instructions in the readme if this is going live.
Link to your package's repository:
https://github.com/gmdata-co/dbt-portable-google-sheets
Checklist
This checklist is a cut down version of the best practices that we have identified as the package hub has grown. Although meeting these checklist items is not a prerequisite to being added to the Hub, we have found that packages which don't conform provide a worse user experience.
First run experience
Customisability
Packages for data transformation (delete if not relevant):
Dependencies
Dependencies on dbt Core
require-dbt-version
range indbt_project.yml
. Example: A package which depends on functionality added in dbt Core 1.2 should set itsrequire-dbt-version
property to[">=1.2.0", "<2.0.0"]
.Dependencies on other packages defined in packages.yml:
Interoperability
{{ dbt.except() }}
and{{ dbt.type_string() }}
.users
.Versioning