Implemented date_part in where filter #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevonFulcher
force-pushed
the
time_dimension_filter
branch
from
95cec32 to
acae8fa
Compare
DevonFulcher
force-pushed
the
time_dimension_filter
branch
from
0f19319 to
8d9c031
Compare
tlento
reviewed
Nov 8, 2023
I fixed it now. I'm sorry about that. |
tlento
reviewed
Nov 10, 2023
| self.time_granularity_name: Optional[str] = None | ||
|
|
||
| @property | ||
| def time_dimension_spec(self) -> TimeDimensionSpec: |
There was a problem hiding this comment.
Ah, so this returns a TimeDimension with DEFAULT_TIME_GRANULARITY if neither grain nor date_part are set. Interesting. I think that makes the most sense with where we're heading with time dimension expressions.
Comment on lines
+129
to
+131
| ("{{ TimeDimension('metric_time', 'WEEK', date_part_name='year') }} = '2020'"), | ||
| ("{{ Dimension('metric_time').date_part('year').grain('WEEK') }} = '2020'"), | ||
| ("{{ Dimension('metric_time').grain('WEEK').date_part('year') }} = '2020'"), |
There was a problem hiding this comment.
I hope these aren't case-sensitive. I may add some additional tests on after we merge.
There was a problem hiding this comment.
I had fixed the case sensitivity here dbt-labs/dbt-semantic-interfaces#207. So, date_part was case-sensitive as of this PR, but that change to DSI fixes it.
tlento
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows users to specify
date_partin the where filter. This is useful for the Jinja syntax as well as integrations such as Tableau.