Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted Spec Convenience Method Changes #873

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Nov 15, 2023

Description

This PR includes a set of assorted changes to the convenience methods of the spec classes to make them more consistent in naming / easier to use.

@cla-bot cla-bot bot added the cla:yes label Nov 15, 2023
@plypaul plypaul requested review from tlento and WilliamDee November 15, 2023 05:58
@plypaul plypaul marked this pull request as ready for review November 15, 2023 06:11
Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable!

@plypaul plypaul force-pushed the plypaul--58.2--add-mergable branch from 809c5c6 to 086cee4 Compare November 16, 2023 03:53
Base automatically changed from plypaul--58.2--add-mergable to main November 16, 2023 04:01
….as_spec_set.

This makes it more flexible separate the concerns between InstanceSpecSet and
LinkableSpecSet.
This makes naming more consistent with other classes.
This makes LinkableSpecSet in line with the similar initializer in InstanceSpecSet.
@plypaul plypaul force-pushed the plypaul--58.3--assorted-spec-changes branch from a2f779b to 6331dbb Compare November 16, 2023 04:04
@plypaul plypaul merged commit 54608b9 into main Nov 16, 2023
@plypaul plypaul deleted the plypaul--58.3--assorted-spec-changes branch November 16, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants