✨ zb,zm: Support SignalEmitter<'_> in property getters #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeenix
requested changes
Dec 23, 2024
This addresses a forgotten change from when SignalContext has been renamed to SignalEmitter.
rzvncj
force-pushed
the
add_emitter_to_getters
branch
from
8e4a9df to
03cf0e0
Compare
rzvncj
force-pushed
the
add_emitter_to_getters
branch
from
03cf0e0 to
28803ad
Compare
zeenix
reviewed
Dec 24, 2024
rzvncj
force-pushed
the
add_emitter_to_getters
branch
2 times, most recently
from
ea952d2 to
c2fbd2b
Compare
Thanks for the prompt and helpful reviews! Contributing to zbus has been a very enjoyable experience. |
Haha, you just have a very healthy attitude. 👍 Many people get annoyed by my perfectionism and leave PRs hanging forever. 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.