Don't require an owned value for property setters. #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeenix
reviewed
Dec 27, 2024
| @@ -62,7 +62,7 @@ impl Properties { | |||
| &self, | |||
| interface_name: InterfaceName<'_>, | |||
| property_name: &str, | |||
| value: Value<'_>, | |||
| value: &Value<'_>, | |||
There was a problem hiding this comment.
Unfortunately, this will be a breaking change since this is a public API. :(
There was a problem hiding this comment.
Hmm, ok, lmk if / how you want to deal with it and I can update the patch. Alternatively feel free to just close this (or tag it as deferred or whatever you want :))
There was a problem hiding this comment.
I'll just tag it I guess. I hope you're around to rebase when 6.0 is being released. :)
I wrote this as I was thinking about dbus2#1180, but not sure it's worth the complexity. If you think there are some other things that might use it, please go ahead and merge it, otherwise feel free to close :)
emilio
force-pushed
the
no-clone-value
branch
from
d146753 to
577de75
Compare
|
I addressed the (somewhat pedantic) clippy lint :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this as I was thinking about #1180, but not sure it's worth the complexity. If you think there are some other things that might use it, please go ahead and merge it, otherwise feel free to close :)