Lower MSRV via workspace configuration #1201
Merged
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeenix
requested changes
Jan 6, 2025
1 task
thomaseizinger
force-pushed
the
chore/lower-msrv
branch
2 times, most recently
from
d76b907 to
a7fdbd3
Compare
In terms of features used in the codebase, 1.77 is the lowest we require.
thomaseizinger
force-pushed
the
chore/lower-msrv
branch
from
a7fdbd3 to
2abe26d
Compare
|
@zeenix Split into two commits and removed unnecessary formatting changes. |
zeenix
approved these changes
Jan 7, 2025
Awesome, thanks for going the extra mile on this. 👍 I wish all contributors were like you. |
Thanks for accepting the change! :) |
|
@thomaseizinger btw, please next time add the emoji itself rather than their codes. Github shows them as emojis so I didn't notice until I checked the local |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowers the MSRV of all packages to 1.77 as per #1107 (comment). I decided to introduce it as a workspace variable to reduce the duplication across the packages.