Fix Value & related API and make them more consistent #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would fail if cherry-picked to 3.0 branch. Some commit along the way has fixed this though so it work on main branch. Let's keep the test case anyway so we don't regress.
instead of Option<T>. We require `TryFrom` anyway so there is no reason to eat that and return `None` instead of an error. Let's give back user their error.
This will allows us to fix Value::downcast_ref signature w/o reducing functionality.
…ce to it This change makes this API a lot more practical as the only types that can transfrom an `&Value` to an `&T` are the ones that are contained inside the `Value` itself. Other types will need to create a new value and they can't return only the reference to it.
This allows for faster retrieval of entries by key, among other things. This is supposed to be a map type anyway.
This makes it consistent with Dict::get and Maybe::get. The previous impelmentation that gives you a `&[Value]` is now available as `inner` method. Fixes dbus2#263.
This makes all `get` methods in zvariant consistent with each other.
zeenix
force-pushed
the
array-get-concrete-type
branch
from
45f004d to
6643ffc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #263.