This repository has been archived by the owner on Apr 25, 2019. It is now read-only.
[HOPSWORKS-591] Conda Admin UI improvements #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 25, 2018 17:05
SirOibaf
reviewed
Jun 19, 2018
| @@ -588,6 +589,24 @@ public Response search(@Context SecurityContext sc, | |||
| libsFound).build(); | |||
| } | |||
|
|
|||
|
|
|||
| @GET | |||
| @Path("/diskusage") | |||
There was a problem hiding this comment.
What's the purpose of this endpoint?
If it is to give information to the users about the size of the project anaconda environment, it shouldn't do a du on the whole anaconda lib, but on the project one.
If the purpose is to give admin information about the size of the anaconda directories, the endpoint shouldn't be here, but in the admin section, and the AllowedRoled shouldn't be DATA_OWNER but HOPS_ADMIN
There was a problem hiding this comment.
It's for the admin to find out about the size of all of the anaconda libraries on each host. Will fix.
There was a problem hiding this comment.
This REST API isn't currently used. The mgmt bean is used. I can remove it.
…me from kagents config.ini file, as GCE fails because hopsworks::default sets the wrong hostname
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure there is no duplicate PR for this issue
Post a link to the associated JIRA issue
https://hopshadoop.atlassian.net/browse/HOPSWORKS-591
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the new behavior (if this is a feature change)?
Show disk usage for Conda on Hopsworks server. Call 'conda clean' on all hosts.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.
Other information: