This repository has been archived by the owner on Apr 25, 2019. It is now read-only.
[HOPSWORKS-634] Show proper warning when mysql is down #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…localhost:8080/app)
… 6.2.3 (#3) [HOPSWORKS-559], [HOPSWORKS-244], [HOPSWORKS-251] Refactor ElasticController to work with Elasticsearch…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure there is no duplicate PR for this issue
Post a link to the associated JIRA issue
https://hopshadoop.atlassian.net/browse/HOPSWORKS-634
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature.
What is the new behavior (if this is a feature change)?
Shows an "Annoucement" on the login page if the mysql server or NDB is not working.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
This works by catching an Exception (runtime exceptions like EclipsePersistenceException are thrown when the DB is not working) at users.findUser() and also at settings.updateVariable(). They now throw an AppException with 503 (service_unavailable) status.
At the javascript controller, we catch a 503 (service_unavailable) to indicate that we couldn't access the DB.