-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
advance image uploader #390
base: main
Are you sure you want to change the base?
Conversation
After spending so many hours around editing SVG I find out it's so hard to edit SVGs and I think it's really no need to edit them anyway. If somebody is uploading SVG he wants to show all of it 100% and it's going to be under the size limit probably and if it's more than that we have no way to reduce its size unless we make a jpeg out of it so I think it's better to give up the SVG support for this and rely on properly positioning them at the showtime. |
Image Editor Component is almost completed. There are 3 issues that need discussion @scco
|
Even if the Image Editor component is completed it's not mergeable yet, since it needs tight integration with the Base Image Upload component. TODOs for completing integration with Base Image Upload:
|
so here is the plan for the "advanced" image uploader that would be reusable for later
heres the architecture / wireframes & actually the design and flow
|
what's the status here? |
@mk1r almost finished. Will be done this week I guess. |
The component is finished. I created a new screen for testing and styling it at /image-uploader and after that, I will integrate it since the integration will depend on #506 . |
added ui for all of this ! will play a bit ping pong with ajand
|
Image Editor is a component that will be used when an image in the Image Uploader doesn't fit in the selected constraint. It will give the user the ability to crop the image into the desired ratio and it will automatically change the image size to fit into the constraint.
specs: