Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds documentation and an example for flink HA #196

Closed
wants to merge 1 commit into from

Conversation

skonto
Copy link

@skonto skonto commented Aug 2, 2017

@joerg84
Copy link
Contributor

joerg84 commented Aug 2, 2017

LGTM, testing later today!

Copy link
Contributor

@joerg84 joerg84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After universe PR is merged!

@@ -76,6 +79,33 @@ core@ip-10-0-6-55 ~ $ docker run -it mesosphere/dcos-flink:1.2.0-1.2 /bin/bash

root@2a9c01d3594e:/flink-1.2.0# ./bin/flink run -m <jobmangerhost>:<jobmangerjobmanager.rpc.port> ./examples/batch/WordCount.jar --input file:///etc/resolv.conf --output file:///etc/wordcount_out
```
### Running with HA

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few spelling mistakes in the below draft.

For clarity would you mind stating that the below is the client configuration.

@joerg84
Copy link
Contributor

joerg84 commented Aug 10, 2017

@skonto could you have a look erons comments?

Otherwise I am happy to merge this after the universe PR.

@tillrohrmann
Copy link

LGTM modulo Eron's comments.

@skonto
Copy link
Author

skonto commented Aug 10, 2017

@joerg84 sure I am on vacations so I am might be a bit slow...

@skonto
Copy link
Author

skonto commented Aug 20, 2017

@joerg84 should I update this PR?

@skonto
Copy link
Author

skonto commented Jun 9, 2019

closing this as had no response.

@skonto skonto closed this Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants