Dt 615 booking conformance uc3 shipper submit updated booking request #11
Conversation
booking/src/main/java/org/dcsa/conformance/standards/booking/BookingScenarioListBuilder.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public String getHumanReadablePrompt() { | ||
| return ("UC3 Submit an Updated booking request using the following parameters:"); |
There was a problem hiding this comment.
We seem to consistently be using UCX: (that is, have a colon after the use-case name). Please align.
| @Override | ||
| public void doHandleExchange(ConformanceExchange exchange) { | ||
| JsonNode responseJsonNode = exchange.getResponse().message().body().getJsonBody(); | ||
| // FIXME: Guard against non-conformant parties | ||
| getDspConsumer() | ||
| .accept( | ||
| new DynamicScenarioParameters( | ||
| responseJsonNode.get("carrierBookingRequestReference").asText(), | ||
| getDspSupplier().get().carrierBookingReference())); | ||
| } |
There was a problem hiding this comment.
Unneeded for this use-case (the CBRR is already recorded in UC1), so please remove this code snippet
| var bookingReference = lastUrlSegment(request.url()); | ||
| // bookingReference can either be a CBR or CBRR. | ||
| BookingState bookingState = BookingState.PENDING_UPDATE_CONFIRMATION; | ||
| var cbrr = cbrToCbrr.getOrDefault(bookingReference, bookingReference); | ||
| var bookingData = persistentMap.load(cbrr); |
There was a problem hiding this comment.
Nit pick: The BookingState bookingState = BookingState.PENDING_UPDATE_CONFIRMATION; line is placed confusing relative to the comment.
I would move the BookingState bookingState = BookingState.PENDING_UPDATE_CONFIRMATION; above the var bookingReference = lastUrlSegment(request.url()); line to avoid this (or below var bookingData = persistentMap.load(cbrr);)
| if (bookingData == null || bookingData.isMissingNode()) { | ||
| return return404(request); | ||
| } | ||
| booking.put("carrierBookingRequestReference", cbrr); |
There was a problem hiding this comment.
Unneeded: The payload should already have a CBRR at this point; there is no need to set it again as PUT is not supposed to be able to change it. Therefore it is confusing at best.
| "/v2/bookings/%s".formatted(cbrr),bookingData); | ||
|
|
||
| addOperatorLogEntry( | ||
| "Sent a Updated booking request with the parameters: %s" |
There was a problem hiding this comment.
| "Sent a Updated booking request with the parameters: %s" | |
| "Sent an updated booking request with the parameters: %s" |
| @Override | ||
| public JsonNode getJsonForHumanReadablePrompt() { | ||
| return getCspSupplier().get().toJson(); | ||
| } |
There was a problem hiding this comment.
UC3 has no JSON associated with the human-readable prompt, and in fact neither does UC1, in both the override should IMO be deleted. Only the initial action that prompts for scenario parameters needs to override this and provide a JSON to go with the text for the user.
nt-gt
deleted the
DT-615-Booking-conformance-UC3-shipper-submit-updated-booking-request
branch
No description provided.