DT-1425,DT-1522 added multi ECP and container pickup and removed noti… #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fication api spec.
nt-gt
requested changes
Sep 4, 2024
There was a problem hiding this comment.
For DT-1425, the note says "not applicable", which sounds like a conditional. I do not see code for. Please clarify whether it needs be a conditional.
For DT-1522, I am told I do not have access to it. Is that issue number correct and if it is, I either need access to it or someone else must be reviewing it.
|
@nt-gt looks like there is a confusion, as there were multiple jiras for empty container related jiras. Could you please review the PR #114. The condition for DT-1425 is here. There was a typo DT-1552 (https://dcsa.atlassian.net/browse/DT-1552) |
nt-gt
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fication api spec.