Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SD-20 Enhancement to OVS Conformance checks #219

Merged
merged 8 commits into from
Nov 13, 2024
Merged

SD-20 Enhancement to OVS Conformance checks #219

merged 8 commits into from
Nov 13, 2024

Conversation

preetamnpr
Copy link
Contributor

@preetamnpr preetamnpr commented Nov 10, 2024 •
edited
Loading

Please note this story actually belongs to SD-20 of OVS. Please refer the story in the JIRA. https://dcsa.atlassian.net/browse/SD-20 .

@preetamnpr preetamnpr requested review from jkosternl, gj0dcsa and palatsangeetha and removed request for jkosternl November 10, 2024 14:52
@jkosternl
Copy link
Collaborator

Hi @preetamnpr, I just checked what SD-17 actually is, and I see: "OVS - write the Dev Portal implementation guide"
I now wonder if that is correct. Can you please rename this PR so it matches the Jira issue and also has a meaningful name? That helps me to efficiently review it and secondly, while merging, your commit message is than automatically also correct. Thanks!

@preetamnpr
Copy link
Contributor Author

Hi @preetamnpr, I just checked what SD-17 actually is, and I see: "OVS - write the Dev Portal implementation guide" I now wonder if that is correct. Can you please rename this PR so it matches the Jira issue and also has a meaningful name? That helps me to efficiently review it and secondly, while merging, your commit message is than automatically also correct. Thanks!

I realized it later that the SD-17 was for the developer portal rather than the OVS checks enhancement.

@jkosternl
Copy link
Collaborator

I realized it later that the SD-17 was for the developer portal rather than the OVS checks enhancement.

No problem, please just update the title of this PR, so it matches reality. If you squash merge it, the used commit messages don't care!

@preetamnpr preetamnpr changed the title Sd 17 SD-20 Enhancement to OVS Conformance checks Nov 11, 2024
jkosternl
jkosternl approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@jkosternl jkosternl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, from the Java perspective. Thanks Preetam!
Please wait for merging on the others (different perspectives).

palatsangeetha
palatsangeetha reviewed Nov 13, 2024
View reviewed changes
ovs/src/main/java/org/dcsa/conformance/standards/ovs/party/OvsPublisher.java
200,
Map.of(API_VERSION, List.of(apiVersion)),
new ConformanceMessageBody(jsonResponseBody));
ArrayNode filteredArray = OBJECT_MAPPER.createArrayNode();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for dynamically generating the response from the static file according to the filter params?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, indeed.. The publisher is created such a way that it exhibits real behavior.

@gj0dcsa gj0dcsa merged commit a687faf into dev Nov 13, 2024
1 check passed
@gj0dcsa gj0dcsa deleted the SD-17 branch November 13, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palatsangeetha palatsangeetha palatsangeetha left review comments

@gj0dcsa gj0dcsa gj0dcsa approved these changes

@jkosternl jkosternl jkosternl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@preetamnpr @jkosternl @gj0dcsa @palatsangeetha