Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD-587 Add extra conditions to handle the MissingNode. #231

Merged
merged 1 commit into from
Nov 26, 2024
Merged

SD-587 Add extra conditions to handle the MissingNode. #231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...src/main/java/org/dcsa/conformance/standards/booking/model/PersistableCarrierBooking.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ public JsonNode asPersistentState() {

public static PersistableCarrierBooking fromPersistentStore(JsonNodeMap jsonNodeMap, String carrierBookingRequestReference) {
var data = jsonNodeMap.load(carrierBookingRequestReference);
if (data == null) {
if (data == null || data.isMissingNode() || !data.isObject()) {
throw new IllegalArgumentException("Unknown CBRR: " + carrierBookingRequestReference);
}
return fromPersistentStore(data);
Expand Down