SD-642 Adjust the isExportDeclarationRequired condition

[preetamnpr]

User description

…ant unit test cases.

---

PR Type

Enhancement

---

Description

• Enhanced export declaration reference validation by implementing a new IS_EXPORT_DECLARATION_REFERENCE_PRESENCE check that:
  • Validates presence of exportDeclarationReference when isExportDeclarationRequired is true
  • Ensures absence of exportDeclarationReference when isExportDeclarationRequired is false
• Added comprehensive unit tests covering all possible scenarios for export declaration reference validation
• Removed deprecated import license reference validation
• Cleaned up booking message templates by removing redundant declaration flags

---

Changes walkthrough 📝

	Relevant files
Enhancement	BookingChecks.java Refactor export declaration reference validation logic      booking/src/main/java/org/dcsa/conformance/standards/booking/checks/BookingChecks.java Replaced separate export/import declaration checks with a single IS_EXPORT_DECLARATION_REFERENCE_PRESENCE check Updated check logic to handle both presence and absence of export declaration reference based on isExportDeclarationRequired flag Removed import license reference check +5/-11
Tests	BookingChecksTest.java Add test coverage for export declaration reference validation booking/src/test/java/org/dcsa/conformance/standards/booking/checks/BookingChecksTest.java Added comprehensive test cases for IS_EXPORT_DECLARATION_REFERENCE_PRESENCE check Tests cover all scenarios: required/not required, present/absent, missing flag cases +45/-0
Configuration changes	*.json Clean up declaration flags from booking message templates booking/src/main/resources/standards/booking/messages/*.json Removed isExportDeclarationRequired and isImportLicenseRequired flags from multiple booking message templates Removed exportDeclarationReference and importLicenseReference from regular.json template

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Logic Validation Verify that the new export declaration reference validation logic correctly handles all edge cases and maintains backward compatibility Data Removal Confirm that removing the import license fields and modifying export declaration fields doesn't break existing integrations

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
General	Add descriptive error message for validation failure cases to improve user experience The ifThenElse condition is missing a description for the 'else' case. Add a descriptive message to help users understand why the exportDeclarationReference must be absent when isExportDeclarationRequired is false. booking/src/main/java/org/dcsa/conformance/standards/booking/checks/BookingChecks.java [194-199] static final JsonContentCheck IS_EXPORT_DECLARATION_REFERENCE_PRESENCE = JsonAttribute.ifThenElse( "Check Export declaration reference presence", JsonAttribute.isTrue(JsonPointer.compile("/isExportDeclarationRequired")), JsonAttribute.mustBePresent(JsonPointer.compile("/exportDeclarationReference")), - JsonAttribute.mustBeAbsent(JsonPointer.compile("/exportDeclarationReference")) + JsonAttribute.mustBeAbsent(JsonPointer.compile("/exportDeclarationReference"), "Export declaration reference must be absent when not required") ); Apply this suggestion Suggestion importance[1-10]: 5 Why: The suggestion improves error messaging by adding a descriptive message for the 'else' case, which would help users better understand validation failures. While helpful for debugging and user experience, it's not critical for functionality.	5

[jkosternl]

Nice Preetam. Please wait for S. as well.