SD-1895 Add JIT 2.0 GET actions #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update example values
* Update JIT schema
…mps are returned later. Add all GET scenario groups.
| import java.util.Arrays; | ||
| import java.util.List; | ||
|
|
||
| public record JitGetPortServiceCallFilters( |
There was a problem hiding this comment.
Isn't this PortCallService?
There was a problem hiding this comment.
Yes, thanks for noticing. As discussed, will fix all your observations in my other branch. The mentioned things are already in there.
Can one of you approve this PR, so I can merge and continue?
palatsangeetha
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All JIT 2.0 GET actions are covered now. But it is not checked yet if the results are okay, returned from the endpoint (like matching IDs, matching result count etc). There are still 2 issues left in Jira, where I can put that into.
Since the
persistentMapis not clean when every scenario starts,flushTimestampsis called on the SSPAction & PortCall Action. Need to fix that in a different way later.