Dt-718 changes for reefer #30
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package org.dcsa.conformance.standards.booking.party; | ||
|
|
||
| import lombok.Getter; | ||
|
|
||
| @Getter | ||
| public enum BookingVariant { | ||
| REGULAR("Regular"), | ||
| REEFER("Reefer"), | ||
| DG("Dangerous Goods"); | ||
|
|
||
| private final String value; | ||
|
|
||
| BookingVariant(String value) { | ||
| this.value = value; | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| { | ||
| "receiptTypeAtOrigin": "CY", | ||
| "deliveryTypeAtDestination": "CY", | ||
| "cargoMovementTypeAtOrigin": "FCL", | ||
| "cargoMovementTypeAtDestination": "FCL", | ||
| "contractQuotationReference": "CONTRACT_QUOTATION_REFERENCE_PLACEHOLDER", | ||
| "carrierExportVoyageNumber": "CARRIER_EXPORT_VOYAGE_NUMBER_PLACEHOLDER", | ||
| "carrierServiceName": "CARRIER_SERVICE_NAME_PLACEHOLDER", | ||
| "isPartialLoadAllowed": false, | ||
| "isExportDeclarationRequired": false, | ||
| "isImportLicenseRequired": false, | ||
| "communicationChannelCode": "AO", | ||
| "isEquipmentSubstitutionAllowed": true, | ||
| "requestedEquipments": [ | ||
| { | ||
| "ISOEquipmentCode": "22RT", | ||
| "units": 1, | ||
| "isShipperOwned": false, | ||
| "commodities": [ | ||
| { | ||
| "HSCodes": ["COMMODITY_HS_CODE"], | ||
| "commodityType": "COMMODITY_TYPE_PLACEHOLDER", | ||
| "cargoGrossWeight": 323.32, | ||
| "cargoGrossWeightUnit": "KGM" | ||
| } | ||
| ], | ||
| "isNonOperatingReefer": false, | ||
| "activeReeferSettings": { | ||
| "temperatureSetpoint": -18, | ||
| "temperatureUnit": "CEL" | ||
| } | ||
| } | ||
| ], | ||
| "documentParties": [ | ||
| { | ||
| "party": { | ||
| "partyName": "DCSA Conformance Toolkit", | ||
| "address": { | ||
| "name": "Mustermann", | ||
| "street": "Strawinskylaan", | ||
| "streetNumber": "4117", | ||
| "floor": "6", | ||
| "postCode": "1077 ZX", | ||
| "city": "Amsterdam", | ||
| "country": "Netherlands" | ||
| }, | ||
| "partyContactDetails": [ | ||
| { | ||
| "name": "Henrik", | ||
| "phone": "+31611444666" | ||
| } | ||
| ] | ||
| }, | ||
| "partyFunction": "BA", | ||
| "isToBeNotified": false | ||
| } | ||
| ], | ||
| "shipmentLocations": [ | ||
| { | ||
| "location": { | ||
| "locationType": "UNLO", | ||
| "UNLocationCode": "POL_UNLOCATION_CODE_PLACEHOLDER" | ||
| }, | ||
| "locationTypeCode": "POL" | ||
| }, | ||
| { | ||
| "location": { | ||
| "locationType": "UNLO", | ||
| "UNLocationCode": "POD_UNLOCATION_CODE_PLACEHOLDER" | ||
| }, | ||
| "locationTypeCode": "POD" | ||
| } | ||
| ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use
jsonNode.putin this case rather than manually constructing a text node.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jsonNode.put("csp", getCspSupplier().get().toJson()); is deprecated. hence used .set for csp and bookingVariant. If you would like I will change it .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not challenging the use
setfor thecsp. I was challenging the use ofsetfor a regular string for which.putis a much better (and not deprecated) option.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.. I will change it.. done !