Avoid creating object mappers all the time #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a single `auto` run for eBL, the `new ObjectMapper()` was profiled to take ~60s CPU time (across all threads). This change sadly does not translate directly into a ~60s wall time improvement. However, it is was trivial to fix and remove the `new ObjectMapper()` line from the profiling. Signed-off-by: Niels Thykier <[email protected]>
|
Note: This deliberately only changes the "core" parts of the framework. Per standard code and the lambda code has not been updated to avoid merge conflicts or to avoid touching code I cannot test. |
gj0dcsa
requested changes
Jan 12, 2024
core/src/main/java/org/dcsa/conformance/core/check/JsonSchemaValidator.java
Show resolved
Hide resolved
core/src/main/java/org/dcsa/conformance/core/toolkit/JsonToolkit.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Niels Thykier <[email protected]>
gj0dcsa
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a single
autorun for eBL, thenew ObjectMapper()was profiled to take ~60s CPU time (across all threads). This change sadly does not translate directly into a ~60s wall time improvement.However, it is was trivial to fix and remove the
new ObjectMapper()line from the profiling.