Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-1217 + DT-1266 #99

Merged
merged 2 commits into from
Jun 18, 2024
Merged

DT-1217 + DT-1266 #99

merged 2 commits into from
Jun 18, 2024

Conversation

nt-gt
Copy link
Collaborator

@nt-gt nt-gt commented Jun 13, 2024

No description provided.

@nt-gt nt-gt marked this pull request as ready for review June 13, 2024 10:49
@nt-gt nt-gt requested a review from preetamnpr June 13, 2024 10:49
@nt-gt
Copy link
Collaborator Author

nt-gt commented Jun 18, 2024

@preetamnpr did you have a look at this one?

@preetamnpr
Copy link
Contributor

@preetamnpr did you have a look at this one?

I will review it ASAP, probably I missed the automated review notification.

@preetamnpr
Copy link
Contributor

Looks like the title of the PR and changes in the PR seems to be mismatch?

@nt-gt
Copy link
Collaborator Author

nt-gt commented Jun 18, 2024

Looks like the title of the PR and changes in the PR seems to be mismatch?

I cannot see the issue? There are two commits, one for each Jira issue listed in the title and the Jira issues in the commit titles match those of the Jira issues in the title. What do you feel the mismatch is?

@preetamnpr
Copy link
Contributor

Looks like the title of the PR and changes in the PR seems to be mismatch?

I cannot see the issue? There are two commits, one for each Jira issue listed in the title and the Jira issues in the commit titles match those of the Jira issues in the title. What do you feel the mismatch is?

Does the PR have the changes for DT-1217 ?

@preetamnpr
Copy link
Contributor

preetamnpr commented Jun 18, 2024

Looks like the title of the PR and changes in the PR seems to be mismatch?

I cannot see the issue? There are two commits, one for each Jira issue listed in the title and the Jira issues in the commit titles match those of the Jira issues in the title. What do you feel the mismatch is?

Does the PR have the changes for DT-1217 ?

I was under the impression that George will provide us the explanation of handling 202 with no notification. Since its Ebl Surrender and I hope that applicable changes belongs to DT-1217 and DT-1266.

@nt-gt
Copy link
Collaborator Author

nt-gt commented Jun 18, 2024

Looks like the title of the PR and changes in the PR seems to be mismatch?

I cannot see the issue? There are two commits, one for each Jira issue listed in the title and the Jira issues in the commit titles match those of the Jira issues in the title. What do you feel the mismatch is?

Does the PR have the changes for DT-1217 ?

I was under the impression that George will provide us the explanation of handling 202 with no notification. Since its Ebl Surrender and I hope that applicable changes belongs to DT-1217 and DT-1266.

Ah, this change is not about the 202 change that apply for BKG and eBL. Instead it moves to 204 for a different reason (consistency with other API calls in these APIs). The DT-1217 should have been DT-1267.

Apologies for the confusion.

@nt-gt nt-gt merged commit e9966fa into dev Jun 18, 2024
1 check passed
@nt-gt nt-gt deleted the DT-1266 branch June 18, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants