Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCS-11: Add CI/CD ADR #26

Merged
merged 3 commits into from
Feb 3, 2025
Merged

DCS-11: Add CI/CD ADR #26

merged 3 commits into from
Feb 3, 2025

Conversation

tonyhu-x
Copy link
Collaborator

@tonyhu-x tonyhu-x commented Feb 3, 2025

No description provided.

Copy link
Contributor

@krishnacheemalapati krishnacheemalapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use - instead of _ in your ADR file names (just to standardize naming conventions, as the example adr, Parth, and I all follow this).

Other than that, looks good to me 👍

@krishnacheemalapati krishnacheemalapati dismissed their stale review February 3, 2025 22:28

Did not get the memo about file naming conventions

@tonyhu-x tonyhu-x merged commit e729e03 into main Feb 3, 2025
@tonyhu-x tonyhu-x deleted the DCS-11 branch February 3, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants